[
https://issues.apache.org/jira/browse/MRRESOURCES-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907021#comment-17907021
]
ASF GitHub Bot commented on MRRESOURCES-151:
--------------------------------------------
elharo commented on code in PR #71:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/71#discussion_r1891829983
##########
src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java:
##########
@@ -239,13 +239,17 @@ public abstract class AbstractProcessRemoteResourcesMojo
extends AbstractMojo {
* javadoc for MavenProject</a> for information about the properties on
the MavenProject.
*/
@Parameter
- protected Map<String, Object> properties = new HashMap<>();
+ protected Map<String, String> properties = new HashMap<>();
/**
* Whether to include properties defined in the project when filtering
resources.
*
+ * @deprecated As Maven Project is available in Velocity context we can
simply use
Review Comment:
nit: As --> as
> Deprecate includeProjectProperties parameter
> --------------------------------------------
>
> Key: MRRESOURCES-151
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-151
> Project: Maven Remote Resources Plugin
> Issue Type: Task
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: next-release
>
>
> As Maven Project is available in Velocity context we can simply use
> {{$project.properties.propertyName}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
