[
https://issues.apache.org/jira/browse/MNG-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907577#comment-17907577
]
Tamas Cservenak commented on MNG-8464:
--------------------------------------
This https://github.com/shrinkwrap/resolver/pull/341 PR is totally wrong, goes
for completely the opposite what Maven4, and even Maven3 (!) wanted:
https://github.com/shrinkwrap/resolver/pull/341 This PR does "manual tampering"
with an _implementation detail_ of Maven. Just like with Resolver local
repository, project local repository location, layout or anything about it
should not be "assumed", but the Maven API should be used to access it.
What this PR does was "common" in Maven2 world, where each plugin did "path
operations" and contained logic to "go directly for file", that later caused a
TON of issues, and problems like plugins being unable to use features like
split repository and so on. This is utterly wrong, is like two steps back.
Something is very wrong, if all this is needed to make things work.
The second PR https://github.com/shrinkwrap/resolver/pull/369 is just as bad as
it is.
In short: your PR makes shrinkwrap depend on internals and direct file access.
How will it behave it tomorrow we change the project repo layout (that is
planned)?
> [Regression] Maven 4-rc-2 breaks Maven ShrinkWrap Resolvers
> -----------------------------------------------------------
>
> Key: MNG-8464
> URL: https://issues.apache.org/jira/browse/MNG-8464
> Project: Maven
> Issue Type: Bug
> Affects Versions: 4.0.0-rc-2
> Reporter: Lenny Primak
> Priority: Critical
>
> This is a regression from rc-1. Caused by MNG-8393 and
> [https://github.com/apache/maven/pull/1963]
> In rc-1 and prior, project-local-repo contained consumer pom, but now it
> contains a build pom {*}only{*}, which breaks the resolvers.
> Consumer POM is needed for shrinkwrap resolvers to work correctly.
> See [https://github.com/shrinkwrap/resolver/pull/369] and
> https://github.com/shrinkwrap/resolver/blob/0d3d07fcd46bdfa38fb59025ab3da259d033ffcd/maven/impl-maven/src/main/java/org/jboss/shrinkwrap/resolver/impl/maven/MavenWorkingSessionImpl.java#L200
> {code:java}
> Caused by: java.lang.reflect.InvocationTargetException
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.jboss.arquillian.container.test.impl.client.deployment.AnnotationDeploymentScenarioGenerator.invoke(AnnotationDeploymentScenarioGenerator.java:164)
> ... 34 more
> Caused by:
> org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 1
> problems while building POM model from
> /Users/lprimak/dev/flowlogix/target/project-local-repo/com.flowlogix/flowlogix-jee/9.x-SNAPSHOT/flowlogix-jee-9.x-SNAPSHOT.pom
> 1/ [FATAL] Non-resolvable parent POM for
> com.flowlogix:flowlogix-jee:9.x-SNAPSHOT: Failed to resolve POM for
> com.flowlogix:jakarta-ee:9.x-SNAPSHOT due to The following artifacts could
> not be resolved: com.flowlogix:jakarta-ee:pom:9.x-SNAPSHOT (absent): Could
> not find artifact com.flowlogix:jakarta-ee:pom:9.x-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @
> com.flowlogix:flowlogix-jee:9.x-SNAPSHOT,
> /Users/lprimak/dev/flowlogix/target/project-local-repo/com.flowlogix/flowlogix-jee/9.x-SNAPSHOT/flowlogix-jee-9.x-SNAPSHOT.pom
> at
> org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.loadPomFromFile(MavenWorkingSessionImpl.java:185)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.loadPomFromFile(MavenWorkingSessionImpl.java:152)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.processAdditionalDependencies(MavenWorkingSessionImpl.java:252)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.resolveProjectLocal(MavenWorkingSessionImpl.java:230)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.resolveProjectLocal(MavenWorkingSessionImpl.java:204)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.resolveDependencies(MavenWorkingSessionImpl.java:305)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.archive.packaging.WarPackagingProcessor.importBuildOutput(WarPackagingProcessor.java:112)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.archive.packaging.WarPackagingProcessor.importBuildOutput(WarPackagingProcessor.java:51)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.PomEquippedMavenImporterImpl.importBuildOutput(PomEquippedMavenImporterImpl.java:49)
> at
> org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.PomEquippedMavenImporterImpl.importBuildOutput(PomEquippedMavenImporterImpl.java:44)
> at
> com.flowlogix.util.ShrinkWrapManipulator.createDeployment(ShrinkWrapManipulator.java:133)
> at
> com.flowlogix.util.ShrinkWrapManipulator.createDeployment(ShrinkWrapManipulator.java:119)
> at
> com.flowlogix.examples.ExceptionPageIT.createDeployment(ExceptionPageIT.java:228)
> at
> com.flowlogix.examples.ExceptionPageIT.createDeploymentDev(ExceptionPageIT.java:224)
> at
> com.flowlogix.examples.Deployments.createDeployment(Deployments.java:33)
> ... 36 more {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
