elharo commented on code in PR #78:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/78#discussion_r1894613365
##########
src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java:
##########
@@ -87,6 +86,15 @@ public class BundleRemoteResourcesMojo extends AbstractMojo {
@Parameter(defaultValue = "${project.build.sourceEncoding}")
private String sourceEncoding;
+ /**
+ * List of required project properties needed to process Velocity
Review Comment:
delete "required" as it's redundant with needed
##########
src/main/mdo/remote-resources.mdo:
##########
@@ -52,12 +52,23 @@ under the License.
</field>
<field>
<name>sourceEncoding</name>
- <version>1.1.0</version>
+ <version>1.1.0+</version>
<description><![CDATA[
Source encoding of the remote resources contained in the bundle.
]]></description>
<type>String</type>
</field>
+ <field>
+ <name>requiredProjectProperties</name>
+ <version>1.2.0+</version>
+ <description><![CDATA[
Review Comment:
CDATA not needed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]