[jira] [Commented] (MRRESOURCES-154) Allow to require project properties by bundle

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/MRRESOURCES-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907580#comment-17907580
 ] 

ASF GitHub Bot commented on MRRESOURCES-154:
--------------------------------------------

elharo commented on code in PR #78:
URL: 
https://github.com/apache/maven-remote-resources-plugin/pull/78#discussion_r1894613365


##########
src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java:
##########
@@ -87,6 +86,15 @@ public class BundleRemoteResourcesMojo extends AbstractMojo {
     @Parameter(defaultValue = "${project.build.sourceEncoding}")
     private String sourceEncoding;
 
+    /**
+     * List of required project properties needed to process Velocity

Review Comment:
   delete "required" as it's redundant with needed



##########
src/main/mdo/remote-resources.mdo:
##########
@@ -52,12 +52,23 @@ under the License.
         </field>
         <field>
           <name>sourceEncoding</name>
-          <version>1.1.0</version>
+          <version>1.1.0+</version>
           <description><![CDATA[
             Source encoding of the remote resources contained in the bundle.
           ]]></description>
           <type>String</type>
         </field>
+        <field>
+          <name>requiredProjectProperties</name>
+          <version>1.2.0+</version>
+          <description><![CDATA[

Review Comment:
   CDATA not needed here





> Allow to require project properties by bundle
> ---------------------------------------------
>
>                 Key: MRRESOURCES-154
>                 URL: https://issues.apache.org/jira/browse/MRRESOURCES-154
>             Project: Maven Remote Resources Plugin
>          Issue Type: New Feature
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.3.0
>
>
> We can have a velocity template in resources bundle.
> Template can use project properties to generate content so we should have 
> possibility to require if property exists in project which use resource 
> bundle.
> Resource bundle author will have a sure thet content will be generated 
> correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)