[ 
https://issues.apache.org/jira/browse/MNGSITE-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908656#comment-17908656
 ] 

ASF GitHub Bot commented on MNGSITE-518:
----------------------------------------

slawekjaranowski commented on code in PR #609:
URL: https://github.com/apache/maven-site/pull/609#discussion_r1899000790


##########
content/apt/guides/development/guide-plugin-documentation.apt.vm:
##########
@@ -215,12 +215,23 @@ public class ExampleMojo
  
 **Site Descriptor 
  
- The site descriptor describes the navigation links and can be found in 
<<<src/site/site.xml>>>. Below is the suggested site 
- descriptor template.
+ The {{{/plugins/maven-site-plugin/examples/sitedescriptor.html}site 
descriptor}} describes the navigation links and the layout of the page.
+ It can be found in <<<src/site/site.xml>>>.
+
+ You must define a {{{../../skins/}skin}}, if you are using a site descriptor.
+ There is no default skin applied automatically.
+
+ Below is the suggested site descriptor template (with maven-fluido-skin).
  
 +--------------+  
 <?xml version="1.0" encoding="UTF-8"?>
 <project>
+  <skin>
+    <groupId>org.apache.maven.skins</groupId>
+    <artifactId>maven-fluido-skin</artifactId>
+    <version>2.0.1</version>

Review Comment:
   we can use:
   ```
   ${context.get("version.maven-fluido-skin")}
   ```
   
   so we will have a version defined in pom





> No default skin
> ---------------
>
>                 Key: MNGSITE-518
>                 URL: https://issues.apache.org/jira/browse/MNGSITE-518
>             Project: Maven Project Web Site
>          Issue Type: Bug
>            Reporter: Delany
>            Priority: Major
>
> When I follow instructions to add documentation to a plugin
> [https://maven.apache.org/guides/development/guide-plugin-documentation.html]
> I get
> {quote}{{Execution default-site of goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M8:site failed: skin cannot 
> be null}}
> {quote}
> There's no mention of skins on that page.
> But at [https://maven.apache.org/skins/index.html]
> it says
> {quote}You get this skin if you don't specify any skin or template.
> {quote}
> If I add a skin in the site descriptor its happy
> {code:java}
> <project>
>   <skin>
>     <groupId>org.apache.maven.skins</groupId>
>     <artifactId>maven-fluido-skin</artifactId>
>     <version>2.0.0-M6</version>
>   </skin>
> ... {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to