kwin commented on code in PR #255:
URL: https://github.com/apache/maven-doxia/pull/255#discussion_r1900801508
##########
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/LastTwoLinesBufferingWriter.java:
##########
@@ -91,4 +91,8 @@ public void flush() throws IOException {
public void close() throws IOException {
out.close();
}
+
+ public boolean isAfterDigit() {
+ return currentLine.length() > 1 &&
Character.isDigit(currentLine.charAt(currentLine.length() - 1));
+ }
Review Comment:
The markdown spec is not very clear in this regard and also different
markdown parses behave differently, therefore it is safer to also consider
those as digits (i.e. escape rather too often than miss one time).
##########
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/LastTwoLinesBufferingWriter.java:
##########
@@ -91,4 +91,8 @@ public void flush() throws IOException {
public void close() throws IOException {
out.close();
}
+
+ public boolean isAfterDigit() {
+ return currentLine.length() > 1 &&
Character.isDigit(currentLine.charAt(currentLine.length() - 1));
+ }
Review Comment:
The markdown spec is not very clear in this regard and also different
markdown parsers behave differently, therefore it is safer to also consider
those as digits (i.e. escape rather too often than miss one time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
