[
https://issues.apache.org/jira/browse/MNG-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MNG-8484:
---------------------------------------
Description:
Consider that it has the unexpected effect of making all empty lists identical
and equal, regardless of type, which might not be what we want. We could simply
use Collections.unmodifiableCollection instead.
This method also converts all collections to lists. That might be intentional,
but if so it should be documented in a comment.
was:
It's only used in org.apache.maven.api.services so move it in there somewhere
and make it package private.
Then consider that it has the unexpected effect of making all empty lists
identical and equal, regardless of type, which might not be what we want. We
could simply use Collections.unmodifiableCollection instead.
This method also converts all collections to lists. That might be intentional,
but if so it should be documented in a comment.
> Perhaps remove BaseRequest.unmodifiable
> ---------------------------------------
>
> Key: MNG-8484
> URL: https://issues.apache.org/jira/browse/MNG-8484
> Project: Maven
> Issue Type: Bug
> Components: API
> Affects Versions: 4.0.0-rc-2
> Reporter: Elliotte Rusty Harold
> Priority: Blocker
> Fix For: 4.0.0-rc-3
>
>
> Consider that it has the unexpected effect of making all empty lists
> identical and equal, regardless of type, which might not be what we want. We
> could simply use Collections.unmodifiableCollection instead.
> This method also converts all collections to lists. That might be
> intentional, but if so it should be documented in a comment.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
