slawekjaranowski commented on code in PR #92:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/92#discussion_r1903292412
##########
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependencyManagementRenderer.java:
##########
@@ -194,7 +196,13 @@ private void renderDependenciesForScope(String scope,
List<Dependency> artifacts
String[] tableHeader = getDependencyTableHeader(hasClassifier);
tableHeader(tableHeader);
+ List<ArtifactRepository> remoteRpositories = new
ArrayList<>(buildingRequest.getRemoteRepositories());
+ List<ArtifactRepository> pluginRpositories = new ArrayList<>(
+ buildingRequest.getPluginArtifactRepositories());
+
for (Dependency dependency : artifacts) {
+ buildingRequest.setRemoteRepositories(remoteRpositories);
+
buildingRequest.setPluginArtifactRepositories(pluginRpositories);
Review Comment:
looks like you set the same repositories list that you read .... effective
will be
```java
buildingRequest.setRemoteRepositories(buildingRequest.getRemoteRepositories())
```
can you create a test which confirm it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
