aamotharald commented on code in PR #50: URL: https://github.com/apache/maven-plugin-testing/pull/50#discussion_r1905051543
########## maven-plugin-testing-harness/src/main/java/org/apache/maven/api/plugin/testing/InjectMojo.java: ########## @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.maven.plugin.testing.junit5; +package org.apache.maven.api.plugin.testing; Review Comment: Hi @slachiewicz , yes this might collide and this I am doing by intent. Consider the following use case: Somebody uses `@InjectMojo`on maven version 3 and creates JUnit Jupiter test cases to test his/her Mojo. Then he/she decides to migrate to Maven4. As the codelines differ between maven3/maven4, there might be glitches / issues. But the migration will be a lot less cumbersome if you don't have to rename all the imports just because the package changes from maven3 to maven4. This is why I would like to have the same Packages on Maven3/4. Does that make sense or should we strictly separate the packages and make the maven3-4 migration cumbersome for the consumers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
