michael-o commented on code in PR #346:
URL: https://github.com/apache/maven-enforcer/pull/346#discussion_r1912545345
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireJavaVendor.java:
##########
@@ -76,15 +76,15 @@ public void execute() throws EnforcerRuleException {
String message = getMessage();
if (message == null) {
message = String.format(
- "%s is an excluded Required Java Vendor
(JAVA_HOME=%s)",
+ "%s is an excluded Required Java Vendor (Detected JDK
%s)",
SystemUtils.JAVA_VENDOR, SystemUtils.JAVA_HOME);
}
throw new EnforcerRuleException(message);
} else if (includes != null &&
!includes.contains(SystemUtils.JAVA_VENDOR)) {
String message = getMessage();
if (message == null) {
message = String.format(
- "%s is not an included Required Java Vendor
(JAVA_HOME=%s)",
+ "%s is not an included Required Java Vendor (Detected
JDK %s)",
Review Comment:
ditto
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireJavaVendor.java:
##########
@@ -76,15 +76,15 @@ public void execute() throws EnforcerRuleException {
String message = getMessage();
if (message == null) {
message = String.format(
- "%s is an excluded Required Java Vendor
(JAVA_HOME=%s)",
+ "%s is an excluded Required Java Vendor (Detected JDK
%s)",
Review Comment:
detected JDK:
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/version/RequireJavaVersion.java:
##########
@@ -145,9 +145,9 @@ private void
setCustomMessageIfNoneConfigured(ArtifactVersion detectedJdkVersion
getLog().debug("Could not parse allowed version range " +
allowedVersionRange + " " + e.getMessage());
version = allowedVersionRange;
}
- String message = String.format(
- "Detected JDK version %s (JAVA_HOME=%s) is not in the
allowed range %s.",
- detectedJdkVersion, SystemUtils.JAVA_HOME, version);
+ String message = "Detected JDK " + SystemUtils.JAVA_HOME
Review Comment:
single quote the value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
