[
https://issues.apache.org/jira/browse/MENFORCER-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912486#comment-17912486
]
ASF GitHub Bot commented on MENFORCER-495:
------------------------------------------
elharo commented on code in PR #346:
URL: https://github.com/apache/maven-enforcer/pull/346#discussion_r1913107263
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireJavaVendor.java:
##########
@@ -76,15 +76,15 @@ public void execute() throws EnforcerRuleException {
String message = getMessage();
if (message == null) {
message = String.format(
- "%s is an excluded Required Java Vendor
(JAVA_HOME=%s)",
+ "%s is an excluded Required Java Vendor (Detected JDK
%s)",
Review Comment:
done
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/version/RequireJavaVersion.java:
##########
@@ -145,9 +145,9 @@ private void
setCustomMessageIfNoneConfigured(ArtifactVersion detectedJdkVersion
getLog().debug("Could not parse allowed version range " +
allowedVersionRange + " " + e.getMessage());
version = allowedVersionRange;
}
- String message = String.format(
- "Detected JDK version %s (JAVA_HOME=%s) is not in the
allowed range %s.",
- detectedJdkVersion, SystemUtils.JAVA_HOME, version);
+ String message = "Detected JDK " + SystemUtils.JAVA_HOME
Review Comment:
I prefer not to. In my experience quote marks just get in the way of copy
and paste, and I don't think there's any ambiguity here if we don't quote.
> Invalid use of JAVA_HOME environment variable
> ---------------------------------------------
>
> Key: MENFORCER-495
> URL: https://issues.apache.org/jira/browse/MENFORCER-495
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: requireJavaVendor, requireJavaVersion
> Affects Versions: 3.4.1
> Reporter: Michael Osipov
> Assignee: Elliotte Rusty Harold
> Priority: Minor
>
> I have received the following on Maven master:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce
> (enforce-bytecode-version) on project maven:
> [ERROR] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion
> failed with message:
> [ERROR] Detected JDK version 1.8.0-392 (JAVA_HOME=/usr/local/openjdk8/jre) is
> not in the allowed range [11,).
> {noformat}
> I have never set {{JAVA_HOME}}. That is confusing. {{JAVA_HOME}} is not the
> same as {{java.home}}.
> Affected spots:
> https://github.com/search?q=repo%3Aapache%2Fmaven-enforcer%20java_home&type=code
> It should likely just print the value...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
