CrazyHZM commented on code in PR #2042:
URL: https://github.com/apache/maven/pull/2042#discussion_r1916480172
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java:
##########
@@ -37,7 +40,17 @@ public void setRootLoggerLevel(Level level) {
case INFO -> "info";
default -> "error";
};
- System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", value);
+
+ String defaultLogLevelKey = "org.slf4j.simpleLogger.defaultLogLevel";
+ String current = System.getProperty(defaultLogLevelKey);
+ if (current == null) {
+ System.setProperty(defaultLogLevelKey, value);
+ } else {
+ LOGGER.warn(
+ "System property '{}' is already set to '{}' - ignoring
log level from -X/-e/-q options",
Review Comment:
No third parameter is added here, but now some Maven command-line parameters
and the slf4j configuration conflict. I agree that the concatenation is better,
but automatic formatting by IDEA is uncomfortable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
