[
https://issues.apache.org/jira/browse/MPIR-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MPIR-479:
---------------------------------------
Description:
Way back when someone got lazy with exceptions and simply converted them into
runtime exceptions without considering what could fail and what the appropriate
response was. Fix this.
{{{color:#0033b3}public {color}{color:#00627a}ProjectInfoProjectStub{color}()
{}}
{{{color:#000000}MavenXpp3Reader pomReader {color}= {color:#0033b3}new
{color}MavenXpp3Reader();}}
{{{color:#0033b3}try {color}({color:#000000}Reader reader {color}=
{color:#000000}ReaderFactory{color}.newXmlReader({color:#0033b3}new
{color}File(getBasedir(), getPOM()))) {}}
{{{color:#871094}model {color}=
{color:#000000}pomReader{color}.read({color:#000000}reader{color});}}
{{setModel({color:#871094}model{color});}}
{{} {color:#0033b3}catch {color}({color:#000000}IOException {color}|
{color:#000000}XmlPullParserException e{color}) {}}
{{{color:#0033b3}throw new {color}RuntimeException({color:#000000}e{color});}}
{{}}}
This might involve changing method saignatures and refactoring code.
was:
{color:#0033b3}public {color}{color:#00627a}ProjectInfoProjectStub{color}() {
{color:#000000}MavenXpp3Reader pomReader {color}= {color:#0033b3}new
{color}MavenXpp3Reader();
{color:#0033b3}try {color}({color:#000000}Reader reader {color}=
{color:#000000}ReaderFactory{color}.newXmlReader({color:#0033b3}new
{color}File(getBasedir(), getPOM()))) {
{color:#871094}model {color}=
{color:#000000}pomReader{color}.read({color:#000000}reader{color});
setModel({color:#871094}model{color});
} {color:#0033b3}catch {color}({color:#000000}IOException {color}|
{color:#000000}XmlPullParserException e{color}) {
{color:#0033b3}throw new {color}RuntimeException({color:#000000}e{color});
}
> ProjectInfoProjectStub sweeps exceptions under the rug
> ------------------------------------------------------
>
> Key: MPIR-479
> URL: https://issues.apache.org/jira/browse/MPIR-479
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Priority: Major
>
> Way back when someone got lazy with exceptions and simply converted them into
> runtime exceptions without considering what could fail and what the
> appropriate response was. Fix this.
>
> {{{color:#0033b3}public {color}{color:#00627a}ProjectInfoProjectStub{color}()
> {}}
> {{{color:#000000}MavenXpp3Reader pomReader {color}= {color:#0033b3}new
> {color}MavenXpp3Reader();}}
> {{{color:#0033b3}try {color}({color:#000000}Reader reader {color}=
> {color:#000000}ReaderFactory{color}.newXmlReader({color:#0033b3}new
> {color}File(getBasedir(), getPOM()))) {}}
> {{{color:#871094}model {color}=
> {color:#000000}pomReader{color}.read({color:#000000}reader{color});}}
> {{setModel({color:#871094}model{color});}}
> {{} {color:#0033b3}catch {color}({color:#000000}IOException {color}|
> {color:#000000}XmlPullParserException e{color}) {}}
> {{{color:#0033b3}throw new {color}RuntimeException({color:#000000}e{color});}}
> {{}}}
>
> This might involve changing method saignatures and refactoring code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
