YaSuenag commented on code in PR #503:
URL:
https://github.com/apache/maven-jlink-plugin/pull/503#discussion_r1967139989
##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -368,6 +368,14 @@ public class JLinkMojo extends AbstractJLinkMojo {
@Parameter
private List<Resource> additionalResources;
+ /**
+ * Add prefix to all of zip entries. It would be treated as a directory if
the prefix ends with "/".
Review Comment:
> Isn't the prefix always supposed to be a directory?
Yes, I think so because if the prefix does not have "/" in its tail, it
breaks JDK directory structure - it means any launcher and `java` command in
`bin` directory would not work. I will fix, and clarify Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
