elharo commented on code in PR #108:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/108#discussion_r1981331871
##########
src/main/java/org/apache/maven/report/projectinfo/SummaryReport.java:
##########
@@ -148,22 +148,14 @@ private String getMinimumJavaVersion() {
String sourceConfigured = getPluginParameter(pluginId, "source");
String targetConfigured = getPluginParameter(pluginId, "target");
- String forkFlag = getPluginParameter(pluginId, "fork");
- String compilerVersionConfigured = null;
- if ("true".equalsIgnoreCase(forkFlag)) {
- compilerVersionConfigured = getPluginParameter(pluginId,
"compilerVersion");
- }
-
- String minimumJavaVersion = compilerVersionConfigured;
Review Comment:
Maybe we should combine the ifs so
if (targetConfigured != null)
becomes
else if if (targetConfigured != null)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
