slawekjaranowski commented on code in PR #312:
URL:
https://github.com/apache/maven-compiler-plugin/pull/312#discussion_r1993035074
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -703,8 +703,39 @@ protected final Optional<Path> getModuleDeclaration(final
Set<File> sourceFiles)
private boolean targetOrReleaseSet;
@Override
- @SuppressWarnings("checkstyle:MethodLength")
public void execute() throws MojoExecutionException,
CompilationFailureException {
+ try {
+ executeReal();
+ } finally {
+ addGeneratedSourcesToProject();
+ }
Review Comment:
I'm not sure if finally is needed ... if something wrong in first method
whole Maven build will be broken anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
