Pankraz76 commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2077449143
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -109,7 +110,7 @@ public void write(XmlWriterRequest<PluginDescriptor>
request) throws XmlWriterEx
* @throws XmlReaderException if an error occurs during the parsing
* @see #toXmlString(Object)
*/
- public static PluginDescriptor fromXml(@Nonnull String xml) throws
XmlReaderException {
Review Comment:
supplement this
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -92,7 +93,7 @@ public void write(XmlWriterRequest<PluginDescriptor> request)
throws XmlWriterEx
} else if (outputStream != null) {
new PluginDescriptorStaxWriter().write(outputStream, content);
} else {
- try (OutputStream os = Files.newOutputStream(path)) {
Review Comment:
supplement this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
