gnodet commented on PR #2303: URL: https://github.com/apache/maven/pull/2303#issuecomment-2863924821
> > Removed too much. Please don't refactor too much without care. > > > > yes > > - SOC to myself and > > - `need to go right, to go fast` by Uncle Bob. > > > > test first this changes already and things get simpler > > - https://github.com/apache/maven/pull/2304 Not sure what you mean, but you removed support for URLs for no good reason. Your first commit what correct, now the PRs is not acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org