Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083517952
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##########
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest<Model> request) throws
XmlWriterException {
Writer writer = request.getWriter();
Function<Object, String> inputLocationFormatter =
request.getInputLocationFormatter();
if (writer == null && outputStream == null && path == null) {
- throw new IllegalArgumentException("writer, outputStream or path
must be non null");
+ throw new IllegalArgumentException("writer, output stream, or path
must be non-null");
Review Comment:
Considering `OOP` leveraging domain logic its kind of clear from the context
now as the code should speak for itself:
`ReadRequest/WriteRequest`
<img width="1865" alt="image"
src="https://github.com/user-attachments/assets/0af239f8-122b-46cb-84f6-8bd7762050ad";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
