desruisseaux commented on code in PR #2219:
URL: https://github.com/apache/maven/pull/2219#discussion_r2094581944
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolverResult.java:
##########
@@ -102,19 +102,27 @@ public class DefaultDependencyResolverResult implements
DependencyResolverResult
* to {@link #addDependency(Node, Dependency, Predicate, Path)}.
*
* @param request the corresponding request
- * @param cache cache of module information about each dependency
Review Comment:
In the particular case of this issue, creating the cache at the location
where the field is defined is the opposite of the intend, because it makes the
`PathModularizationCache` lifetime strongly coupled with the
`DefaultDependencyResolverResult` lifetime. Such coupling makes
`PathModularizationCache` close to useless. It was done that way in the
previous version of this class only as a workaround for the fact that I didn't
knew where to store a session-wide cache, but that workaround was intended to
be temporary.
More details in a next comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
