Pankraz76 commented on PR #2441:
URL: https://github.com/apache/maven/pull/2441#issuecomment-2950083145

   > it should be flushed immediately
   
   yes then flush is mandatory. but is this really important? 
   
   Assuming order will remain the same only let the impl. decide when to flush. 
   
   It feels like optimization not required by test nether by business case, 
assuming and result is the same. 
   
   Only real difference is explicit call of what will done by `gc` as well just 
as it is right now. 
   
   The cleanup order of the `writer` instance remains the same, calling `close` 
and therefore `flush`. Its not our regard of doing so. Thats why try to 
leverage `autocloseable` feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to