slawekjaranowski commented on PR #331:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/331#issuecomment-2952373581

   > Thanks for the link. Alternatively, in the following declaration (added in 
commit 
[09dce4e](https://github.com/apache/maven-compiler-plugin/commit/09dce4e613fbde5fbd88481b01d4a3004c31bea9)):
   > 
   > ```java
   > @Parameter(property = "maven.compiler.moduleVersion", defaultValue = 
"${project.version}")
   > private String moduleVersion;
   > ```
   > 
   > What about removing the default value completely, and let users specify it 
explicitly? The rational given in 
[MCOMPILER-579](https://issues.apache.org/jira/browse/MCOMPILER-579) (that 
`${project.version}` is not a valid module version when the version ends with 
`-SNAPSHOT`) seems quite convincing.
   
   when we remove default value we will break a current behavior


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to