jira-importer commented on issue #49: URL: https://github.com/apache/maven-rar-plugin/issues/49#issuecomment-2952489197
**[Hervé Boutemy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hboutemy)** commented rar lifecycle mapping has been done for MNG-150 in r232602 in august 2005, see http://svn.apache.org/viewvc?view=rev&revision=232602 rar ArtifactHandler definition in components.xml has been done in r593857 on 11/11/2007, released in Maven 2.0.8, see http://svn.apache.org/viewvc?view=rev&revision=593857 but the definition is somewhat different from your proposal: ```xml <component> <role>org.apache.maven.artifact.handler.ArtifactHandler</role> <role-hint>rar</role-hint> <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation> <configuration> <type>rar</type> <language>java</language> <addedToClasspath>true</addedToClasspath> </configuration> </component> ``` instead of ```xml <component> <role>org.apache.maven.artifact.handler.ArtifactHandler</role> <role-hint>rar</role-hint> <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation> <configuration> <type>rar</type> <extension>rar</extension> <includesDependencies>true</includesDependencies> <language>java</language> <addedToClasspath>false</addedToClasspath> </configuration> </component> ``` Then my question is: should the actual configuration be modified? 1. add \<extension>rar\</extension> 2. add \<includesDependencies>true\</includesDependencies> 3. change \<addedToClasspath>true\</addedToClasspath> to \<addedToClasspath>false\</addedToClasspath> I'm not a rar expert, so my opinion on the topic is weak :) BTW, I'll change MNG-3147 to mark it as fixed in Maven 2.0.8 And when we're ok with the changes to do, I'll create another MNG issue For the dispatch of the diverse ArtifactHandler configurations from Maven Core to corresponding plugins, I think it is another topic. Don't know if it is already covered in an existing Jira issue... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
