adangel commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2135104993
########## .pmd/ruleset.xml: ########## @@ -0,0 +1,27 @@ +<?xml version="1.0"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<ruleset name="DoD" + description="pragmatic approach to maintaining code quality in large-scale" Review Comment: > strange that its not detected: > > is this: > > * supposed to be like this? > > * any good? Assuming you are talking about your "problem", that the ruleset description is not detected and PMD says it is missing. Is this correct? Please be more clear in what you write/ask/..., thanks! I always need to guess what you are talking about... The ruleset description must be a _element_, and not an attribute, so: ```xml <ruleset> <description>My description</description> ... </ruleset> ``` See also https://docs.pmd-code.org/latest/pmd_userdocs_making_rulesets.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
