jira-importer opened a new issue, #315:
URL: https://github.com/apache/maven-build-cache-extension/issues/315

   **[Alexander 
Schwartz](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ahus1)** 
opened 
**[MBUILDCACHE-37](https://issues.apache.org/jira/browse/MBUILDCACHE-37?redirect=false)**
 and commented
   
   I'm trying to create a configuration where the extension is disabled by 
default and can be enabled by some key users as a opt-in. 
   
   My first attempt: 
   * in the XML, set `cache.configuration.enabled` to `false`
     -> This disables it by default
   * On the CLI, set `-Dmaven.build.cache.enabled=true`
     -> This was intended to enable it "opt in" - but failed, see below.
   
   The problem: 
   
   The code in
   
   
https://github.com/apache/maven-build-cache-extension/blob/2d262e133749abb5163969b9c0b2f0f2056e7951/src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java#L181-L184
   
   will use the "disable" state in the XML. 
   
   Suggested change: `maven.build.cache.enabled` should override the setting 
`cache.configuration.enabled` in the XML. 
   
   
   ---
   
   **Affects:** 1.0.0
   
   **Remote Links:**
   - [GitHub Pull Request #37
   ](https://github.com/apache/maven-build-cache-extension/pull/37)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to