jira-importer commented on issue #225: URL: https://github.com/apache/maven-jar-plugin/issues/225#issuecomment-2956682899
**[Jochen Wiedmann](https://issues.apache.org/jira/secure/[email protected])** commented Attached you find an updated version of the first patch. This patch is taken against the svn code base. Creating the patch this way has one disadvantage: As the patches build on each other, I have to wait now until the first patch is accepted before I submit the second. As for the code style: I am using the Maven Formatter for Eclipse. However, I am hesitating to use automatic reformatting, because it could increase the patch size. Automatic formatting is, IMO, something that the committer should use, and not the contributor. In other words, if I have formatting errors from time to time, please bear with me and change them silently. I'll doing my best to obey a code style which is unusual for me. Following your suggestion in 3. eliminates the necessity to modify the supplied Map. In other words, an immutable Map (like Collections.EMPTY_MAP) is fine. I'll change the upcoming patches in that sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
