jira-importer commented on issue #231:
URL: 
https://github.com/apache/maven-jar-plugin/issues/231#issuecomment-2956684236

   **[Brett 
Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)**
 commented
   
   - default values should be given with default-value instead of an 
initialising value (the basedir won't be correctly aligned otherwise)
   - this technique won't work especially well with multiple modules projects
   - I'm not sure we want the Apache-specific NOTICE file in here. Perhaps it 
should be a part of the license specification.
   
   Isn't a better workaround just to use the \<resources> mechanism for this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to