jira-importer commented on issue #270:
URL: 
https://github.com/apache/maven-jar-plugin/issues/270#issuecomment-2956692023

   **[Benjamin 
Bentmann](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bentmann)**
 commented
   
   If ever, a simply boolean option like "addLicence" is not flexibile enough. 
Some people may call the file "LICENSE.txt" and others just "LICENSE". You need 
at least the possibility to specify the path to the license file:
   
   ```xml
   <configuration>
     <license>LICENSE.txt</license>
   </configuration>
   ```
   
   Then, this is just one file. Tomorrow people want to include a NOTICE file 
as well or something else. If the JAR plugin should really be extended for this 
purpose instead of simply reusing existing resources capabilities, it would be 
more flexible to add a parameter that accepts a full-blown fileset, i.e. 
directory with some includes/excludes, just like the "filesets" parameter for 
the maven-clean-plugin.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to