jira-importer commented on issue #255: URL: https://github.com/apache/maven-jar-plugin/issues/255#issuecomment-2956688877
**[Olivier Lamy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=olamy)** commented Thanks for patch but I'm not sure adding a new parameter to set the default manifest file is needed. Because the manifestFile configuration is in the the archive configuration part. Something with readonly should be better like ``` /** * Path to the default MANIFEST file to use will be use if useDefaultManifestFile is set to true * * @parameter expression="${project.build.outputDirectory}/META-INF/MANIFEST.MF" * @required * @readonly */ private File defaultManifestFile; /** * Set to true to enable the use of the defaultManifestFile * * @parameter expression="${jar.useDefaultManifestFile}" default-value="false" */ private boolean useDefaultManifestFile; ``` And I have added a test to not override the manifestFile in the archive configuration if it exists. Even if the user set useDefaultManifestFile to true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
