jira-importer commented on issue #260:
URL: 
https://github.com/apache/maven-jar-plugin/issues/260#issuecomment-2956689946

   **[William 
Ferguson](https://issues.apache.org/jira/secure/[email protected])**
 commented
   
   The patch adds `@requiresDependencyResolution` tags of **runtime** to
   * JarMojo
   * JarSignMojo
   * JarSignVerifyMojo
   
   And a `@requiresDependencyResolution` tag of **test** to
   * TestJarMojo
   
   I tried to put together a test case, but the existing test cases were not 
particualrly helpful as a starting point. To test you need to ensure that with 
the dependency list shown below, only  commons-code and commons-io appear in 
the manifest classpath for jar:jar etc.
   
   ```
   <dependencies>
                
        <dependency>
                <groupId>commons-codec</groupId>
                <artifactId>commons-codec</artifactId>
                <scope>compile</scope>
                <version>1.3</version>
        </dependency>
                
        <dependency>
                <groupId>commons-io</groupId>
                <artifactId>commons-io</artifactId>
                <scope>runtime</scope>
                <version>1.2</version>
        </dependency>
                
        <dependency>
                <groupId>commons-lang</groupId>
                <artifactId>commons-lang</artifactId>
                <scope>provided</scope>
                <version>2.1</version>
        </dependency>
                
        <dependency>
                <groupId>commons-logging</groupId>
                <artifactId>commons-logging</artifactId>
                <scope>test</scope>
                <version>1.0.4</version>
        </dependency>
                
   </dependencies>
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to