jira-importer commented on issue #655:
URL: 
https://github.com/apache/maven-javadoc-plugin/issues/655#issuecomment-2957342605

   **[Gert 
Vanderseypen](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=seypeg)**
 commented
   
   I debugged in the javadocplugin (version 2.9) and it seems that there is 
probably something missing in the method AbstractJavadocMojo.getSourcePaths().
   
   When getSourcePaths() is called in AbstractJavadocMojo, line 1855
   
   it seems the following is returned:
   
[C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\src\main\java,
 
C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\src\main\javadoc,
 
C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\target\distro-javadoc-sources\dep2-0.0.1-SNAPSHOT-sources]
   
   > this clearly includes BOTH the javadoc and resources from the main 
project, but it misses the resources from the dependent project dep2
   
   so the method should have returned
   
[C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\src\main\java,
 
C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\src\main\javadoc,
 
C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\target\distro-javadoc-sources\dep2-0.0.1-SNAPSHOT-sources,
 
C:\UserTemp\myfolder\indigo\eclipse\workspace-javadoc-test\Service\target\distro-javadoc-sources\dep2-0.0.1-SNAPSHOT-javadoc-resources]
   
   It is clear that the intention of the getSourcePath() is to return both the 
paths of the sources and the javadoc resources, both of the main project and 
the dependent projects!
   But the problem is that getSourcePath() doesn't make a call to 
resolveDependencyBundles(), so it can not see yet the unpacked 
javadoc-resources because they are not yet there.
   
   Therefore I suggest the following fix:
   In resolveDependencyBundles() at the end of the method, now also make a call 
to resolveDependencyJavadocBundles(SourceResolverConfig)
   
   Probably this should do the job right then....
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to