jira-importer commented on issue #742:
URL: 
https://github.com/apache/maven-javadoc-plugin/issues/742#issuecomment-2957349309

   **[Sebastian 
Marsching](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=smarsching)**
 commented
   
   I attached a patch that fixes the problem for me.
   
   The patch uses a slightly different approach than outlined in the issue 
description. Changing AbstractJavadocMojo.createAndResolveArtifact and 
JavadocPathArtifact seemed to have too much side effects. With my very limited 
knowledge of the code I cannot guarantee that this would not break anything.
   
   The patch only modifies AbstractJavadocMojo.getResource and uses the 
straight-forward way of using the dependency information to resolve a 
dependency artifact. For fixing the resource loading from dependencies, this 
patch is sufficient.
   
   I still think that createAndResolveArtifact's behavior of always resolving 
to the pom.xml is not correct. At least in some places, it is used in a way 
that does not seem compatible with this behavior. However, my knowledge of the 
whole plugin code is too limited to understand what the desired outcome would 
be in these cases (resolving to the referenced project source directory or 
resolving to the "default" artifact of the referenced project).
   
   I think that my patch is so simple that it is not protected under any 
copyright laws, but for practical purposes, I hereby declare that I release it 
to the public domain.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to