jira-importer commented on issue #325:
URL: 
https://github.com/apache/maven-invoker-plugin/issues/325#issuecomment-2957780027

   **[Benjamin 
Bentmann](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=bentmann)**
 commented
   
   Just some comments on the data model suggested by Stephen's patch:
   - There's a boolean attribute "failure" written out. I suggest that we allow 
for an enum-like value here, say "result" which could take the values 
"failure-pre-hook", "failure-build", "failure-post-hook", "success" and "skip" 
(could be a future extension) for more precise diagnostic.
   - In case of a failure, the report should be capable to record a failure 
message (i.e. exception message or build exit code).
   
   If I can join the party in time, I will try to introduce some simple bean to 
hold/collect the data/state of a project instead of passing its path, duration, 
error etc. around as individual variables. This refactoring should help to 
avoid those util methods like `isSetupProject()`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to