jira-importer commented on issue #107:
URL: 
https://github.com/apache/maven-source-plugin/issues/107#issuecomment-2959535023

   **[Dennis 
Lundberg](https://issues.apache.org/jira/secure/[email protected])**
 commented
   
   I can now confirm that 2.0.2 works as describe in my previous comment.
   
   I'm considering changing from
   
   ```
   if ( resourceExcludes == null || resourceExcludes.size() == 0 )
   {
       excludes = FileUtils.getDefaultExcludes();
   }
   else
   {
       excludes = (String[]) resourceExcludes.toArray( new 
String[resourceExcludes.size()] );
   }
   ```
   
   to
   
   ```
   if ( resourceExcludes == null || resourceExcludes.size() == 0 )
   {
       excludes = FileUtils.getDefaultExcludes();
   }
   else
   {
       List allExcludes = new ArrayList();
       allExcludes.addAll( FileUtils.getDefaultExcludesAsList() );
       allExcludes.addAll( resourceExcludes );
       excludes = (String[]) allExcludes.toArray( new 
String[allExcludes.size()] );
   }
   ```
   
   Does that sound right to you Daniel?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to