jira-importer commented on issue #115:
URL: 
https://github.com/apache/maven-source-plugin/issues/115#issuecomment-2959536160

   **[Peter 
Lynch](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=plynch)** 
commented
   
   I think this patch highlights a nasty side effect. Of course since 
classifier use is loosely defined, these leads to all sorts of bad plugin 
behavior when it comes to using classifiers.
   
   To be more percise, how about building a war file with classifiers of dev, 
qa and prod.
   
   With this patch there is no way to distinguish between dev,qa and prod 
sources, yet the final war file name can be deployed as
   
   myproject-1.0.0-dev.war
   
   Where 'dev' is the war plugin classifier. When sources get deployed for 
prod,qa and dev, they will override each other in the repo
   
   myproject-1.0.0-sources.war
   
   So you'll never know what sources you got by the filename.
   
   The only work around I see is to avoid the use of classifier all together 
and make the version something like
   
   \<version>1.0.0-dev\</version>
   
   which means SNAPSHOT version has to be
   
   \<version>1.0.0-dev-SNAPSHOT\</version>
   
   because "-SNAPSHOT" needs to be at the end of the version string.  And to 
depend on this in another pom becomes (notice no classifier)
   
   \<dependency>
   \<artifactId>myproject\</artifactId>
   \<groupId>myproject\</groupId>
   \<version>1.0.0-dev\</version>
   \</dependency>
   -Peter
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to