jira-importer commented on issue #166:
URL: 
https://github.com/apache/maven-source-plugin/issues/166#issuecomment-2959545725

   **[Stephan 
Schroevers](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=stephan202)**
 commented
   
   I just noticed [plexus-archiver PR 
#5](https://github.com/codehaus-plexus/plexus-archiver/issues/5) which 
describes this issue, and the patch attached there by user 
[eicki](https://github.com/eicki) does indeed sufficiently resolve the issue. 
After applying the patch and running the test once more:
   
   ```
   Running second test...
   Testing 
org.apache.maven.plugins:maven-source-plugin:3.0.1-SNAPSHOT:jar-no-fork with 
128m:
   Total time: 3.746 s
   Final Memory: 38M/114M
   Testing 
org.apache.maven.plugins:maven-source-plugin:3.0.1-SNAPSHOT:jar-no-fork with 
256m:
   Total time: 3.122 s
   Final Memory: 41M/229M
   Testing 
org.apache.maven.plugins:maven-source-plugin:3.0.1-SNAPSHOT:jar-no-fork with 
512m:
   Total time: 2.940 s
   Final Memory: 39M/277M
   Testing 
org.apache.maven.plugins:maven-source-plugin:3.0.1-SNAPSHOT:jar-no-fork with 
1024m:
   Total time: 3.037 s
   Final Memory: 40M/422M
   Testing 
org.apache.maven.plugins:maven-source-plugin:3.0.1-SNAPSHOT:jar-no-fork with 
2048m:
   Total time: 3.040 s
   Final Memory: 47M/764M
   Testing 
org.apache.maven.plugins:maven-source-plugin:3.0.1-SNAPSHOT:jar-no-fork with 
4096m:
   Total time: 3.104 s
   Final Memory: 46M/1215M
   ```
   
   That's not quite as good as the performance we saw with 
`maven-source-plugin` 2.4, but probably more than good enough. Can we please 
have this patch applied?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to