jira-importer commented on issue #193:
URL: 
https://github.com/apache/maven-source-plugin/issues/193#issuecomment-2959554914

   **[Elliotte Rusty 
Harold](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elharo)** 
commented
   
   There's an assumption here that there's only one source encoding for the 
archive. That's not necessarily true. In particular, I've seen test files that 
are deliberately encoded in various encodings precisely to test the handling of 
those encodings. This is quite common when you're writing XML tooling, for 
example. However, maybe that's only going to show up in resources, not in test 
sources?
   
   Also, what happens when shading a project? The shaded project and the 
shading project might not have the same encoding.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to