[
https://issues.apache.org/jira/browse/SCM-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959935#comment-17959935
]
ASF GitHub Bot commented on SCM-19:
-----------------------------------
jira-importer commented on issue #281:
URL: https://github.com/apache/maven-scm/issues/281#issuecomment-2964582972
**[Torbjorn Eikli
Smorgrav](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=smorgrav)**
commented
I think the ScmFileStatus should be independent of the providers.
It should define its own semantics.
The CVS provider should return added when a file is added.
And I think patched is redundant.
I have a related problem working with Bazaar and I need a method that
indicates if
the status indicates some kind of change eg. hasDiff().
I have made a patch where I tried to comment each status and added that
hasDiff method to
show you what I mean.
Take a look
> resolve file status ambiguities
> -------------------------------
>
> Key: SCM-19
> URL: https://issues.apache.org/jira/browse/SCM-19
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Task
> Components: maven-scm-api
> Reporter: Brett Porter
> Assignee: Torbjorn Eikli Smorgrav
> Priority: Major
> Fix For: 1.0-beta-3
>
> Attachments: MNG-19-maven-scm-api.patch, MNG-19_1-maven-scm-api.patch
>
>
> currently ScmFileStatus just reports whatever the provider gave back, but
> means different things in different SCM's.
> eg. "updated" in CVS is UPDATED or PATCHED, in SVN it is UPDATED or MERGED.
> "added" in CVS is UPDATED, in SVN it is ADDED.
> The API should hide this from the user, though perhaps be able to give the
> extended info if necessary.
> I suggest isXXX flags instead:
> isUpdated()
> isAdded() - just came from an update
> isMerged()
> isInConflict()
> isNew() - new locally
> etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
