jira-importer commented on issue #324:
URL: https://github.com/apache/maven-scm/issues/324#issuecomment-2964585755

   **[Dennis 
Lundberg](https://issues.apache.org/jira/secure/[email protected])**
 commented
   
   I can confirm that the tests run successfully using revision 374523.
   
   But I do think that the root of the problem is still there. Running the 
tests succeeds, but they produce 6 ERROR lines in the output, which seems to be 
ignored. They look like this:
   
   [ERROR] ParseException Caught
   java.text.ParseException: Unparseable date: "4/21/04 1:05:00 PM PDT"
   at java.text.DateFormat.parse(DateFormat.java:335)
   at 
org.apache.maven.scm.util.AbstractConsumer.parseDate(AbstractConsumer.java:79)
   
   The reason for these exceptions is this. If no pattern is specified in a 
call to
   parseDate( String date, String userPattern, String defaultPattern )
   a SimpleDateInstance is created using the users default locale. This assumes 
that the ChangeLog that is being parsed uses the same date format as the users 
default locale.
   
   As I stated in a previous comment, I don't know much about Starteam, so 
please correct me if I'm wrong here:
   Wouldn't it be better to assume a locale of en_US if no pattern is specified?
   
   By using a DateFormat factory method I managed to do this in 
AbstractConsumer, which made the test run successfully **without** any ERROR 
lines. I'll attach a patch shortly. I do not know, however, how this would 
affect normal usage. Perhaps someone knowledgeable in Starteam can step up and 
shed some light on this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to