jira-importer commented on issue #370:
URL: https://github.com/apache/maven-scm/issues/370#issuecomment-2964590033

   **[Chris 
Graham](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=chrisgwarp)**
 commented
   
   I think this issue can be closed, as I can build the entire SCM project, and 
I do not have bzr installed.
   
   Additionally, the other means to pass the tests, is to check for the 
existance of the tool (using ScmTestCase.isSystemCmd()), as is done in the cvs, 
svn and git tests.
   
   There is quite a bit of variety in the implementation of all of the 
providers, not surprising given the age of the code base and the number of 
people who have worked on it over the years.
   
   I would like to see a bit of cleanup, to bring consistency in implementation 
to the code base.
   
   I don't agree with Emmanuel's comments. Yes they are easy to obtain and 
install, however, this goes against the general maven ethos of running maven 
and it will download and install what it needs to run.
   
   So I'd like to see any and all tests that call the underlying executable 
(obviously all of the non-java implementations) moved to the Tck tests.
   The JUnit tests that remain should be the command line tests and any other 
tests (parsing the URL string, testing consumers etc) to remain where they are.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to