[ 
https://issues.apache.org/jira/browse/SCM-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961041#comment-17961041
 ] 

ASF GitHub Bot commented on SCM-334:
------------------------------------

jira-importer commented on issue #547:
URL: https://github.com/apache/maven-scm/issues/547#issuecomment-2964602106

   **[Michael 
Koch](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mkoch)** 
commented
   
   Single quoting the whole password is easier that checking for special chars 
and quoting them individually.  Nevertheless, as you probably assumed, any 
single quotes in the password will still need to be quoted.
   
   I guess that this problem also applies to the user name. Perhaps all 
arguments should be quoted to be on the safe side.
   




> Faulty svn commandline is generated for passwords containing special chars
> --------------------------------------------------------------------------
>
>                 Key: SCM-334
>                 URL: https://issues.apache.org/jira/browse/SCM-334
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.0
>         Environment: All
>            Reporter: Jan Lisse
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 1.1
>
>         Attachments: patch.txt
>
>
> If i use a svn password containing a semicolon with the 
> maven-scm-provider-svnexe, the commandline generated by SvnCommandlineUtils 
> is faulty, because
> the password is not quoted. Passwords containing other special chars might 
> cause problems too. 
> Solution: Enclosing the password for the commandline in single quotes solves 
> this problem. 
> I have attached a patch for SvnCommandlineUtils that fixes this issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to