[ 
https://issues.apache.org/jira/browse/SCM-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960994#comment-17960994
 ] 

ASF GitHub Bot commented on SCM-313:
------------------------------------

jira-importer opened a new issue, #536:
URL: https://github.com/apache/maven-scm/issues/536

   **[Kohsuke 
Kawaguchi](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=kohsuke)**
 opened 
**[SCM-313](https://issues.apache.org/jira/browse/SCM-313?redirect=false)** and 
commented
   
   BazaarCheckOutCommand line 71 has the following code:
   
   ```
           // Do the actual checkout
           String[] checkout_cmd = new String[]{BRANCH_CMD, url, 
checkoutDir.getAbsolutePath()};
           BazaarConsumer checkout_consumer = new BazaarConsumer( getLogger() );
           BazaarUtils.execute( checkout_consumer, getLogger(), 
checkoutDir.getParentFile(), checkout_cmd );
   
           // Do inventory to find list of checkedout files
           String[] inventory_cmd = new String[]{INVENTORY_CMD};
           BazaarCheckOutConsumer consumer = new BazaarCheckOutConsumer( 
getLogger(), checkoutDir );
           ScmResult result = BazaarUtils.execute( consumer, getLogger(), 
checkoutDir, inventory_cmd );
   
           return new CheckOutScmResult( consumer.getCheckedOutFiles(), result 
);
   ```
   
   This code doesn't check for the error in the branch command, so when that 
fails the error is not reported correctly.
   
   
   ---
   
   **Affects:** 1.0-rc1
   




> baazar : Check out command fails to report an error
> ---------------------------------------------------
>
>                 Key: SCM-313
>                 URL: https://issues.apache.org/jira/browse/SCM-313
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-bazaar
>    Affects Versions: 1.0-rc1
>            Reporter: Kohsuke Kawaguchi
>            Assignee: Olivier Lamy
>            Priority: Major
>             Fix For: 1.2
>
>
> BazaarCheckOutCommand line 71 has the following code:
> {noformat}
>         // Do the actual checkout
>         String[] checkout_cmd = new String[]{BRANCH_CMD, url, 
> checkoutDir.getAbsolutePath()};
>         BazaarConsumer checkout_consumer = new BazaarConsumer( getLogger() );
>         BazaarUtils.execute( checkout_consumer, getLogger(), 
> checkoutDir.getParentFile(), checkout_cmd );
>         // Do inventory to find list of checkedout files
>         String[] inventory_cmd = new String[]{INVENTORY_CMD};
>         BazaarCheckOutConsumer consumer = new BazaarCheckOutConsumer( 
> getLogger(), checkoutDir );
>         ScmResult result = BazaarUtils.execute( consumer, getLogger(), 
> checkoutDir, inventory_cmd );
>         return new CheckOutScmResult( consumer.getCheckedOutFiles(), result );
> {noformat}
> This code doesn't check for the error in the branch command, so when that 
> fails the error is not reported correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to