[
https://issues.apache.org/jira/browse/SCM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960344#comment-17960344
]
ASF GitHub Bot commented on SCM-134:
------------------------------------
jira-importer commented on issue #384:
URL: https://github.com/apache/maven-scm/issues/384#issuecomment-2964590903
**[Trygve
Laugstøl](https://issues.apache.org/jira/secure/[email protected])**
commented
Is this really necessary? I would think that only the checkout and export
commands (not sure if the latter exist) should set the CVSROOT as in all the
other cases you already have an existing checkout and cvs should use the
information stored there. I'm not sure what cvs will do if the given CVS root
doesn't match what's in CVS/Root.
> Set CVSROOT consistently in all commands in cvs-provider
> --------------------------------------------------------
>
> Key: SCM-134
> URL: https://issues.apache.org/jira/browse/SCM-134
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-cvs
> Affects Versions: 1.0-beta-3
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Priority: Major
> Fix For: 1.0-beta-3
>
> Attachments: SCM-134.patch
>
>
> Most of the commands in the cvs provider use the command line argument "-d
> CVSROOT", but not all of them.
> The attached patch adds "-d CVSROOT" to these commands:
> * CvsDiffCommand
> * CvsStatusCommand
> * CvsUpdateCommand
> This change also made it necessary to alter the CvsUpdateCommandTest so that
> it works on Windows.
> That test now uses CvsScmTestUtils.getScmUrl() to get an scmUrl.
> CvsScmTestUtils.getScmUrl() has been corrected to use the vertical bar "|" as
> the delimiter in all places of the scm url.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
