jira-importer commented on issue #743: URL: https://github.com/apache/maven-scm/issues/743#issuecomment-2964617840
**[Tomasz Krakowiak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=niematojaktomasz)** commented I would like to implement support of submodules in git scm providers. This is what I think it should be implemented (pseudocode): ``` checkin(repository, fileSet, options){ gitmodules = listGitSubmodules();// Non-recursive for(gitmodule : gitmodules){ moduleFileSet = narrowFileSetToModule(repository, gitmodule, fileset); // Returns subset of files narrowed // to those contained in module's directory. // (relative paths are resolved to absolute // paths or relative to module's directory) if(!isEmpty(moduleFileSet)){ if(!isSubmoduleInitialized(repository, gitmodule)){ return "Git submodule " + gitmodule + "is not initialized"; } moduleRepository = submoduleRepository(repository, submodule); result = checkin(moduleRepository, moduleFileSet, options); if(!isSuccess(result)){ return result; } fileSet.add(submodule); } } ... // Do the same thing as currently. } ``` I'm only worried about using scm connection for submodules not configured in pom. Still everything should work as long everything is properly configured in git (i would not recommend providing submodule url overriding). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
