[
https://issues.apache.org/jira/browse/SCM-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17960452#comment-17960452
]
ASF GitHub Bot commented on SCM-131:
------------------------------------
jira-importer opened a new issue, #405:
URL: https://github.com/apache/maven-scm/issues/405
**[Dennis
Lundberg](https://issues.apache.org/jira/secure/[email protected])**
opened
**[SCM-131](https://issues.apache.org/jira/browse/SCM-131?redirect=false)** and
commented
There are a couple of reasons for this, in ValidateMojo:
1. The check to see if the scmDeveloperConnection is not null is done on the
scmConnection
2. The `@parameter` definitions are wrong for both the the scmConnection and
scmDeveloperConnection
The check for scmConnection is never run either because of of the wrong
`@parameter` definitions. But the actual value from the pom is normally checked
anyway because the default-value for connectionUrl in AbstractScmMojo is
${pom.scm.connection}. But if you run it like this:
mvn scm:validate -DconnectionUrl=invalidScmUrl
the value of pom.scm.connection will not be checked.
The supplied patch fixes these problems and logs an extra error the tells
the user the value of the invalid scm connection url, to help resolve the
problem.
---
**Attachments:**
-
[SCM-131.patch](https://issues.apache.org/jira/secure/attachment/12718530/SCM-131.patch)
(_1.76 kB_)
> mvn scm:validate does not validate the developerConnection in the pom
> ---------------------------------------------------------------------
>
> Key: SCM-131
> URL: https://issues.apache.org/jira/browse/SCM-131
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-plugin
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Priority: Major
> Fix For: 1.0-beta-3
>
> Attachments: SCM-131.patch
>
>
> There are a couple of reasons for this, in ValidateMojo:
> # The check to see if the scmDeveloperConnection is not null is done on the
> scmConnection
> # The @parameter definitions are wrong for both the the scmConnection and
> scmDeveloperConnection
> The check for scmConnection is never run either because of of the wrong
> @parameter definitions. But the actual value from the pom is normally checked
> anyway because the default-value for connectionUrl in AbstractScmMojo is
> ${pom.scm.connection}. But if you run it like this:
> mvn scm:validate -DconnectionUrl=invalidScmUrl
> the value of pom.scm.connection will not be checked.
> The supplied patch fixes these problems and logs an extra error the tells the
> user the value of the invalid scm connection url, to help resolve the problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
