jira-importer commented on issue #880: URL: https://github.com/apache/maven-scm/issues/880#issuecomment-2964631011
**[Mirko Friedenhagen](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mfriedenhagen)** commented Hello Robert, * I agree using `String` compare feels like a hack. On the other side, rethrowing the `IOException` as `IllegalArgumentException` is IMO a clean solution in this case, I do not think it should come to this. * Using `canonicalPath` is platform agnostic as well, it will deliver a Linux path on Linux, a MacOSX path on MacOSX and a Windows path on Windows. * Tests are running successfully on Mac OS X (you have to trust me on this one :-)) and on Linux (http://huschteguzzel.de/hudson/job/maven-scm/4/) as well. * I use a fork BTW (https://github.com/mfriedenhagen/maven-scm), I will give it a shot to get a working solution using `URI` or `isAncestor` this weekend. * BTW: the `URI` solution has to use `canonicalFile` nonetheless, so the `IOException` has to be handled anyway. Regards Mirko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
