jira-importer commented on issue #887: URL: https://github.com/apache/maven-scm/issues/887#issuecomment-2964631337
**[Svend Hansen](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=svendhhh)** commented I don't think the canonical path is causing the problem, but it's just revealing it. I'm not completely sure I understand the code and how it _should_ be working, but as far as I can see: 1) The files in the `ScmFileSet` passed into the two methods at actual runtime seem to be absolute, so using them with the ScmFileSet's `basedir` doesn't seem to make sense? 2) All the tests seem to set the `basedir` to '.' and then pass in a separate `workingDirectory` or `workingDir`, which it self seems to be relative (e.g. "baz/qux"). 3) I guess this breaks _less_ in linux as `/home/me/project/home/me/project/pom.xml` is still a valid file path (though it would be pointing to a wrong place, of course). I'm not sure if the bug is that the method doesn't handle absolute paths (before my change), or that the paths of the files are absolute. I think that the latter would be a bug somewhere else in the containing/calling maven modules (maven release plugin, etc). How to I create a patch? Do I just commit my changes through SVN? I can write a Junit test that breaks without my change, but works with... Or should I just add another test method to the `PerforceEditCommandTest` and `PerforceCheckInCommandTest`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
