jira-importer commented on issue #886: URL: https://github.com/apache/maven-scm/issues/886#issuecomment-2964631287
**[Petr Kozelka](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pkozelka)** commented Hi Olivier, attached scm-changelog-limit-wrapped.patch contains the request-style as you suggested. Few implementation notes: - to keep the changes minimalistic, especially in the implementation part, I am reusing as much of existing "argument rich" methods code as possible; rewriting these might require heavy testing, so it's perhaps better to leave it up to separate contributions - on the API side, I deprecated all other "changelog" overloads to clearly indicate the (as I suppose) preferred calling style - ScmRequest holds all the data, most of them within a CommandParameters object; this simplifies passing the data down to the implementation side - no method chaining introduced yet but it might be a nice next improvement - this request/result style of passing api parameters might be similarly useful for other commands, I will keep that in mind when submitting patches in future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
