jira-importer commented on issue #918: URL: https://github.com/apache/maven-scm/issues/918#issuecomment-2964632953
**[Andrei Pozolotin](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=andrei.pozolotin)** commented I took a look. few ideas: 1) "/" feels like a hack; who guarantees its presence ? 2) could you differentiate via all of: File.exists() File.isFile() File.isDirectory() ? 3) "/" probably should be File.separator ? 4) need File.getCanonicalFile() to guard against symlinks ? 5) need File.getAbsolutePath() to actually render File.separator suffix ? 6) only one of oldFilePath or newFilePath is actually present on file system for File.exists() to work, could be logic error in :: if ( status == ScmFileStatus.RENAMED ) {} :: block, if treating both same way ? 7) if original issue is path/file overlap, may be should detect specifically only that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
