[ 
https://issues.apache.org/jira/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962235#comment-17962235
 ] 

ASF GitHub Bot commented on SCM-606:
------------------------------------

jira-importer commented on issue #820:
URL: https://github.com/apache/maven-scm/issues/820#issuecomment-2964625855

   **[Mark 
Struberg](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=struberg)**
 commented
   
   I guess I c what you mean:
   
   "followed by the following information at least once for each commit"
   That's exactly the reason why we cannot clean the author and date 
information!
   If two or more following lines (right behind each other) got changed in the 
_same_ commit, then the author+committer info will NOT be contained in the 
blame info!
   
   E.g. the first line looks like this
   
   342345234aef32323214 2 2 3
   author
   author-time
   ...
   committer-time
   ..
   filename myfile.txt
   summary thesummaryIentered
   \t[tab] changed content of this line
   
   but the following 2 lines (summary=3 = last number of the original sha-1 
line)
   342345234aef32323214 3 3
   \t[tab] changed content of the 2nd line
   342345234aef32323214 4 4
   \t[tab] changed content of the 3nd line
   
   Means they will NOT contain the author info again, but 'reuse' the info 
above.
   




> UnsupportedOperationException on blame GIT
> ------------------------------------------
>
>                 Key: SCM-606
>                 URL: https://issues.apache.org/jira/browse/SCM-606
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Wish
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.4
>            Reporter: Fabien Bousquet
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: GitBlame_UnsupportedOperationException.patch, 
> SCM606_bis.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code. 
> In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at 
> org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for 
> example) which is to return a 
> result (with a success to false) ?
> In other word replace :
> {code}
>   throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.", 
> stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException 
> may be raised because is 
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618 
> Do you agree with that ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to